davidhewitt commented on code in PR #14868:
URL: https://github.com/apache/datafusion/pull/14868#discussion_r1973391022
##########
datafusion/physical-plan/src/spill.rs:
##########
@@ -214,18 +260,85 @@ mod tests {
let schema = batch1.schema();
let num_rows = batch1.num_rows() + batch2.num_rows();
let (spilled_rows, _) = spill_record_batches(
- vec![batch1, batch2],
+ &[batch1, batch2],
spill_file.path().into(),
Arc::clone(&schema),
)?;
assert_eq!(spilled_rows, num_rows);
let file = BufReader::new(File::open(spill_file.path())?);
- let reader = FileReader::try_new(file, None)?;
+ let reader = StreamReader::try_new(file, None)?;
- assert_eq!(reader.num_batches(), 2);
assert_eq!(reader.schema(), schema);
+ let batches = reader.collect_vec();
+ assert!(batches.len() == 2);
+
+ Ok(())
+ }
+
+ #[test]
+ fn test_batch_spill_and_read_dictionary_arrays() -> Result<()> {
Review Comment:
I confirmed that this test fails on main with the error in #4658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
