davidhewitt commented on code in PR #14868:
URL: https://github.com/apache/datafusion/pull/14868#discussion_r1973375630
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -439,36 +440,35 @@ impl ExternalSorter {
// `self.in_mem_batches` is already taken away by the sort_stream, now
it is empty.
// We'll gradually collect the sorted stream into self.in_mem_batches,
or directly
// write sorted batches to disk when the memory is insufficient.
- let mut spill_writer: Option<IPCWriter> = None;
+ let mut spill_writer: Option<IPCStreamWriter> = None;
Review Comment:
👍 I'll rebase on this now, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
