davidhewitt commented on code in PR #14868: URL: https://github.com/apache/datafusion/pull/14868#discussion_r1973375283
########## datafusion/physical-plan/src/spill.rs: ########## @@ -59,13 +58,13 @@ pub(crate) fn read_spill_as_stream( /// /// Returns total number of the rows spilled to disk. pub(crate) fn spill_record_batches( - batches: Vec<RecordBatch>, + batches: &[RecordBatch], Review Comment: This function is only `pub(crate)`, so I think it's probably better to make the change and remove the (small) overhead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
