jonahgao commented on code in PR #14824:
URL: https://github.com/apache/datafusion/pull/14824#discussion_r1967850713
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -148,6 +155,15 @@ impl AggregateUDFImpl for Count {
"count"
}
+ // In AggregateFunctionPlanner, wildcard is converted to count(1)
+ //
+ // count() -> count(1)
Review Comment:
I think they have the same root cause, which is the rewriting by
`AggregateFunctionPlanner` and `Count::schema_name()` introducing duplicate
names, and they could all be fixed by using aliases. The old
`CountWildcardRule` used `NamePreserver` to achieve a similar effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
