jayzhan211 commented on code in PR #14824:
URL: https://github.com/apache/datafusion/pull/14824#discussion_r1967780563
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -148,6 +155,15 @@ impl AggregateUDFImpl for Count {
"count"
}
+ // In AggregateFunctionPlanner, wildcard is converted to count(1)
+ //
+ // count() -> count(1)
Review Comment:
I think the issue here is quite different than the test covered in extended
test.
duplicated schema case is executable now
```
query error DataFusion error: Schema error: Schema contains duplicate
unqualified field name "count\(\*\)"
select count(1) * count(2);
```
`select count(), count(*)` duplicated name in projection is another issue
But I agree, this query should be executable too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
