alamb commented on code in PR #14824:
URL: https://github.com/apache/datafusion/pull/14824#discussion_r1967841221
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -148,6 +155,15 @@ impl AggregateUDFImpl for Count {
"count"
}
+ // In AggregateFunctionPlanner, wildcard is converted to count(1)
+ //
+ // count() -> count(1)
Review Comment:
BTW I verified that both of those queries run in `datafusion` 44 and 45 but
does not run on main. Thus this is a regression.
I agree with @jayzhan211 that the issue is different than what is causing
the sqlite tests to fail in main
I have filed a ticket to track this:
- https://github.com/apache/datafusion/issues/14855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
