alamb commented on code in PR #14669:
URL: https://github.com/apache/datafusion/pull/14669#discussion_r1957305771
##########
datafusion/sql/src/planner.rs:
##########
@@ -224,7 +224,24 @@ impl PlannerContext {
}
}
-/// SQL query planner
+/// SQL query planner and binder
+///
+/// This struct is used to convert a SQL AST into a [`LogicalPlan`].
+///
+/// You can control the behavior of the planner by providing [`ParserOptions`].
+///
+/// It performs the following tasks:
+///
+/// 1. Name and type resolution (called "binding" in other systems). This
+/// phase looks up table and column names using the [`ContextProvider`].
+/// 2. Mechanical translation of the AST into a [`LogicalPlan`].
+///
+/// It does not perform type checking, semantic analysis, type coercion, or
Review Comment:
This is a good point that some non trivial amount of semantic analysis and
checking is done in the planner. I removed this text to make it:
```rust
/// It does not perform type coercion, or perform optimization, which are
done
/// by subsequent passes.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
