alamb commented on code in PR #14669:
URL: https://github.com/apache/datafusion/pull/14669#discussion_r1957305049
##########
datafusion/expr/src/planner.rs:
##########
@@ -62,39 +75,44 @@ pub trait ContextProvider {
not_impl_err!("Recursive CTE is not implemented")
}
- /// Getter for expr planners
+ /// Return [`ExprPlanner`] extensions for planning expressions
fn get_expr_planners(&self) -> &[Arc<dyn ExprPlanner>] {
&[]
}
- /// Getter for the data type planner
+ /// Return [`TypePlanner`] extensions for planning data types
fn get_type_planner(&self) -> Option<Arc<dyn TypePlanner>> {
None
}
- /// Getter for a UDF description
+ /// Return the scalar function with a given name, if any
fn get_function_meta(&self, name: &str) -> Option<Arc<ScalarUDF>>;
- /// Getter for a UDAF description
+
+ /// Return the aggregate function with a given name, if any
fn get_aggregate_meta(&self, name: &str) -> Option<Arc<AggregateUDF>>;
- /// Getter for a UDWF
+
+ /// Return the window function with a given name, if any
fn get_window_meta(&self, name: &str) -> Option<Arc<WindowUDF>>;
- /// Getter for system/user-defined variable type
+
+ /// Return the system/user-defined variable type, if any
+ ///
+ /// A user defined variable is typically accessed via `@@var_name`
Review Comment:
This is a good call -- I also pushed a commit to add documentation to
`is_system_variable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
