xudong963 commented on PR #14650: URL: https://github.com/apache/datafusion/pull/14650#issuecomment-2658391157
> Also, it looks like the failing CI tests are related to the sort enforcement. Such as not removing unnecessary sorts in some of the children. The problem is that the code still depends on the `update_plan_from_children` in `update_sort_ctx_children`, even if children aren't changed in `update_sort_ctx_children`. -- This is making things weird. I did more updates: 1. Rename the `update_plan_from_children` to `update_sort_ctx_children_data` to show what the method does to update `data`. 2. Call `update_plan_from_children` after the `children` of `PlanContext` is changed. 3. After creating the `PlanContext`, if you can't guarantee they(`PlanContext`'s plan's children's Execution and `PlanContext`'s children's Execution) are consistent, call `update_plan_from_children` to sync. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
