wiedld commented on PR #14650: URL: https://github.com/apache/datafusion/pull/14650#issuecomment-2657959828
> Thank you for starting to work on this code @xudong963 > > BTW I believe @wiedld is also plans to work to make this code better, see > > > Maybe you can work together to improve things Happy to work together @xudong963 . Right now I'm working on: * put in a fix for [this bug](https://github.com/apache/datafusion/pull/14637) (and let reviewers correct the approach 😆 ). * I'm in the process of refactoring the `EnforceDistribution` tests since: * those tests are still [tightly coupled](https://github.com/apache/datafusion/blob/68306ac842e13133ad2df1676104b7dfc108c27c/datafusion/core/tests/physical_optimizer/enforce_distribution.rs#L407-L409) with `EnforceSorting` from when they were a single optimization. * we have already demonstrated that this optimizer pass is [not idempotent](https://github.com/influxdata/arrow-datafusion/pull/60/files#r1955367535). * make it a bit easier to understand and iterate upon I can make sure to add you as a reviewers on those. Please lmk if/how you want to coordinate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
