jamxia155 commented on code in PR #14194:
URL: https://github.com/apache/datafusion/pull/14194#discussion_r1956625049
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1326,19 +1326,46 @@ pub async fn from_read_rel(
table_ref: TableReference,
schema: DFSchema,
projection: &Option<MaskExpression>,
+ filter: &Option<Box<Expression>>,
+ best_effort_filter: &Option<Box<Expression>>,
) -> Result<LogicalPlan> {
let schema = schema.replace_qualifier(table_ref.clone());
+ let mut filters = vec![];
+ if filter.is_some() {
+ let filter_expr = consumer
+ .consume_expression(&(filter.clone().unwrap()), &schema)
+ .await?;
+ filters.append(
+ &mut split_conjunction(&filter_expr)
Review Comment:
That cleaned things up quite a bit, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
