kazuyukitanimura commented on code in PR #1377:
URL: https://github.com/apache/datafusion-comet/pull/1377#discussion_r1951731866
##########
.github/actions/rust-test/action.yaml:
##########
@@ -29,7 +29,7 @@ runs:
shell: bash
run: |
cd native
- cargo clippy --color=never --all-targets --workspace -- -D warnings
+ cargo clippy --color=never --all-targets --workspace --exclude
datafusion-objectstore-hdfs -- -D warnings
Review Comment:
Since we have
```
- name: Build common module (pre-requisite for Rust tests)
shell: bash
run: |
cd common
../mvnw -B clean compile -DskipTests
```
in the same file, we should be able to get JAVA_HOME ? If you would like to
get away with `exclude` for now, do you mind filing an issue and put `TODO`
here with the issue link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
