comphead commented on code in PR #1377:
URL: https://github.com/apache/datafusion-comet/pull/1377#discussion_r1951169297
##########
.github/actions/rust-test/action.yaml:
##########
@@ -29,7 +29,7 @@ runs:
shell: bash
run: |
cd native
- cargo clippy --color=never --all-targets --workspace -- -D warnings
+ cargo clippy --color=never --all-targets --workspace --exclude
datafusion-objectstore-hdfs -- -D warnings
Review Comment:
the crate requires valid JVM path, if not excluded it will ask for JAVA_HOME
which probably is not expected for the users building the Comet without HDFS
support? At lease now Comet doesn't require JAVA HOME set up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
