chenkovsky commented on PR #14057: URL: https://github.com/apache/datafusion/pull/14057#issuecomment-2641808013
> > would you mind to add some tests about stopping system column propagation? I haven't seen them on your branch? > > have you seen these? > > https://github.com/apache/datafusion/blob/af6e9725965938e68a6f401dd4ef7fe9eed0c6f1/datafusion/core/tests/sql/system_columns.rs#L318-L376 so for _row_id save load problem. so in your implementation "a system column stops being a system column once it's projected" ? for stopping system column propagation, do you tested other logical plans e.g. union intersect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
