chenkovsky commented on PR #14057: URL: https://github.com/apache/datafusion/pull/14057#issuecomment-2641751804
> @chenkovsky the main difference between the two approaches is how to transmit the information on which columns are system columns and which aren't. The approach in this PR does it explicitly by modifying `DFSchema`, `TableProvider` and a couple other spots and also manipulating the meaning of field indexes in `DFSchema`. The approach in #14362 does it by adding metadata to `Field`. They both work but each have pros and cons. > > How about we check with @alamb, @Omega359 and @jayzhan211 what they think sounds best? > > Either way I still think we should name these `system columns` not `metadata columns` to avoid confusion with `DFScheama::metadata_schema` and `DFSchema::metadata` meaning two very different things, etc. @adriangb of course, I want to listen other's opinions. and I also think name is a small thing. changing to system column are also ok. besides _rowid save and load problem. before compare pros and cons, would you mind to add some tests about stopping system column propagation? I haven't seen them on your branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
