wiedld commented on code in PR #14329: URL: https://github.com/apache/datafusion/pull/14329#discussion_r1937693958
########## datafusion/expr/src/logical_plan/extension.rs: ########## @@ -54,6 +57,22 @@ pub trait UserDefinedLogicalNode: fmt::Debug + Send + Sync { /// Return the output schema of this logical plan node. fn schema(&self) -> &DFSchemaRef; + /// Return the list of invariants. + /// + /// Implementing this function enables the user to define the + /// invariants for a given logical plan extension. + fn invariants(&self) -> Vec<Invariant> { + vec![] + } + + /// Perform check of invariants for the extension node. + fn check_invariants(&self, check: InvariantLevel, plan: &LogicalPlan) -> Result<()> { Review Comment: Removed the use of the `Invariant` API with the encapsulated FnMut. Since it's unnecessary complication if we are not providing invariant FnMut checks run over the builtin logical node. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org