wiedld commented on code in PR #14329:
URL: https://github.com/apache/datafusion/pull/14329#discussion_r1931107283
##########
datafusion/expr/src/logical_plan/invariants.rs:
##########
@@ -41,19 +61,54 @@ pub enum InvariantLevel {
Executable,
}
+/// Apply the [`InvariantLevel::Always`] check at the root plan node only.
pub fn assert_always_invariants(plan: &LogicalPlan) -> Result<()> {
// Refer to
<https://datafusion.apache.org/contributor-guide/specification/invariants.html#relation-name-tuples-in-logical-fields-and-logical-columns-are-unique>
assert_unique_field_names(plan)?;
Ok(())
}
+/// Visit the plan nodes, and confirm the [`InvariantLevel::Executable`]
+/// as well as the less stringent [`InvariantLevel::Always`] checks.
pub fn assert_executable_invariants(plan: &LogicalPlan) -> Result<()> {
Review Comment:
Documents the existing behavior.
* The `assert_always_invariants()` (renamed to
`assert_always_invariants_at_current_node`) assess only the current node, and
does not assess the remaining DAG.
* this was a previous decision for performance reasons.
* whereas the `assert_executable_invariants()` (a) visits the subplan, and
(b) validates the always and executable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
