andygrove commented on code in PR #1332:
URL: https://github.com/apache/datafusion-comet/pull/1332#discussion_r1934474112
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -988,6 +988,9 @@ fn is_datafusion_spark_compatible(
return true;
}
match from_type {
+ DataType::Null => {
+ matches!(to_type, DataType::List(_))
+ }
Review Comment:
No, we will likely need to add support for more casts from `Null` to other
types in the future, especially once we add support for more complex types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
