kazuyukitanimura commented on code in PR #1332:
URL: https://github.com/apache/datafusion-comet/pull/1332#discussion_r1934452868
##########
native/core/src/execution/operators/scan.rs:
##########
@@ -304,11 +304,7 @@ fn scan_schema(input_batch: &InputBatch, data_types:
&[DataType]) -> SchemaRef {
.map(|(idx, c)| {
let datatype =
ScanExec::unpack_dictionary_type(c.data_type());
// We don't use the field name. Put a placeholder.
- if matches!(datatype, DataType::Dictionary(_, _)) {
- Field::new_dict(format!("col_{}", idx), datatype,
true, idx as i64, false)
Review Comment:
Just making sure, will this work even the `enableFastEncoding` option is
disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
