jayzhan211 commented on code in PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#discussion_r1933110734
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -584,23 +544,7 @@ fn get_valid_types(
match target_type_class {
TypeSignatureClass::Native(native_type) => {
let target_type = native_type.native();
- if &logical_type == target_type {
Review Comment:
The rule of thumb is that try to be consistent with either Postgres and
DuckDB for the functions and don't make the casting too general that cast any
type to any type since this turns invalid query into valid one and it is not
easy to know that given the test is not covered.
Based on that,
1. Cast from Binary to String 👍🏻
2. Cast from Numeric to String 👎🏻 (At least for the string functions
changed in this PR)
3. Cast from Float to Integer 👎🏻 (At least not for `repeat`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
