shehabgamin commented on code in PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#discussion_r1933055108
##########
datafusion/functions/src/string/contains.rs:
##########
@@ -59,7 +64,13 @@ impl Default for ContainsFunc {
impl ContainsFunc {
pub fn new() -> Self {
Self {
- signature: Signature::string(2, Volatility::Immutable),
Review Comment:
For `Signature::string` all input args must be a `String` or Dictionary with
`String` value. For `Signature::Coercible`, the input args must be able to cast
to a `String` (dictated via `default_cast_for`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
