eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931802942
##########
datafusion/sql/src/set_expr.rs:
##########
@@ -36,8 +40,17 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
right,
set_quantifier,
} => {
- let left_plan = self.set_expr_to_plan(*left, planner_context)?;
- let right_plan = self.set_expr_to_plan(*right,
planner_context)?;
+ let left_plan = self.set_expr_to_plan(*left.clone(),
planner_context)?;
Review Comment:
Yes absolutely
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -165,7 +165,9 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
schema: &DFSchema,
planner_context: &mut PlannerContext,
) -> Result<Expr> {
- let mut expr = self.sql_expr_to_logical_expr(sql, schema,
planner_context)?;
+ // The location of the original SQL expression in the source code
+ let mut expr =
+ self.sql_expr_to_logical_expr(sql.clone(), schema,
planner_context)?;
Review Comment:
It works! Thank you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
