eliaperantoni commented on code in PR #13664: URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931790064
########## datafusion/common/src/config.rs: ########## @@ -250,6 +250,11 @@ config_namespace! { /// specified. The Arrow type system does not have a notion of maximum /// string length and thus DataFusion can not enforce such limits. pub support_varchar_with_length: bool, default = true + + /// When set to true, the source locations relative to the original SQL Review Comment: And that's okay I think, I wanted this PR to be more digestible and a PoC for what can be achieved with `Diagnostic`. Rolling it out to more places will come later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org