eliaperantoni commented on PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#issuecomment-2612103530
Added tests. I tried to find an approach that makes tests easy to read and
write so that we don't have to manually edit the numbers of lines and columns
like:
```rust
assert_eq!(span, Span {
start: Location {
line: 1,
column: 13
},
start: Location {
line: 1,
column: 18
},
});
```
Instead, you do:
```rust
let query = "SELECT /*a*/namex/*a*/ FROM users";
let spans = get_spans(query);
assert_eq!(span, spans["a"]);
```
The spans are delimited in the query with comments and you can retrieve them
easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
