eliaperantoni commented on PR #13664: URL: https://github.com/apache/datafusion/pull/13664#issuecomment-2610077654
@alamb As agreed, I implemented all the errors that I previously implemented but in a less invasive way, only adding `Span` to `Column`. Here's some examples: <img width="500" src="https://github.com/user-attachments/assets/3affccc3-3f9f-4d37-8b4c-f04e2164c139"/> <img width="500" src="https://github.com/user-attachments/assets/574aa784-0c7d-43fe-a552-2b2342ea53ab"/> <img width="500" src="https://github.com/user-attachments/assets/51582c07-66e4-40aa-a52b-76a6ee810f0b"/> <img width="500" src="https://github.com/user-attachments/assets/3fd368f4-ac68-41f8-822e-60e47288d408"/> <img width="700" src="https://github.com/user-attachments/assets/72a8dc89-b803-4eb6-852d-cdf3e65c6f1f"/> <img width="700" src="https://github.com/user-attachments/assets/32efeb4f-aad9-41c9-a1e3-600a00d525c3"/> <img width="500" src="https://github.com/user-attachments/assets/7a845f8d-b1fe-47da-8060-1ee85dbf7f15"/> Note that the particular way that we show the diagnostics here is something that we have implemented and is not part of the PR. We think DataFusion shouldn't be too opinionated about the way the data is displayed to the user, but only provide it to a frontend. So CLI output like this can be built just as well as an LSP, a VSCode extension, a bare JSON report, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
