comphead commented on PR #14020: URL: https://github.com/apache/datafusion/pull/14020#issuecomment-2583243383
> NOTE: One notable thing I want to point out here. find_in_set(str, str_list) doesn't work if str or str_list is Scalar::Utf8View (string view literal), which is true for both the main branch and the original version of this PR (unit tests for these cases have been added in this PR, seems like a bug?! 🤔) Is possible to provide a test case so we can file a ticket if this is undesired behavior? The performance is definitely better, thanks @tlm365 I'm going to merge the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
