tlm365 commented on PR #14020:
URL: https://github.com/apache/datafusion/pull/14020#issuecomment-2577664206
@comphead Thanks for reviewing,
> I think it is a good PR the way it is. One thing comes to my mind which
probably relevant for other string functions as well.
>
> So we do `split(',')` for every search pattern value, but most likely that
argument will be literal like `SELECT FIND_IN_SET(a, "s,q,l");` so we can do
split only once.
>
> I think we need to have a check a literal or column somewhere and we can
optimize even further having this info, WDYT @tlm365 ?
Oh yes, your suggestion is very reasonable. I will try to implement it. TYSM
❤
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
