mbutrovich commented on PR #1245: URL: https://github.com/apache/datafusion-comet/pull/1245#issuecomment-2583017470
Thanks for raising this issue. I definitely learned something new about JDK8's performance issue with ConcurrentHashMap, as your microbenchmark demonstrates. However, it's not clear to me that the overall query performance will be meaningfully impacted by the amount of code being brought in to be maintained, and I'm not sure if we want to set a precedent for maintaining too many code paths for different JDK versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
