andygrove commented on PR #1245: URL: https://github.com/apache/datafusion-comet/pull/1245#issuecomment-2580835682
Thanks for the contribution, @SteNicholas, but I am not convinced this helps with performance. We only have a single use of `computeIfAbsent` and the "compute" part is just instantiating a class, so it should not block. Do I understand this correctly? ```scala taskIdMapsForShuffle.computeIfAbsent(handle.shuffleId, _ => new OpenHashSet[Long](16)) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
