wackywendell commented on issue #13853:
URL: https://github.com/apache/datafusion/issues/13853#issuecomment-2578203665
After looking more closely, it looks like `datafusion-substrait` has a
`protoc` feature:
https://github.com/apache/datafusion/blob/7af6aa9e51fde2bbf7a12c4096e999041ef6ffc6/datafusion/substrait/Cargo.toml#L56
Building locally, it looks like this feature covers everything we need it to
for docs. Using `protoc@3.12.4` downloaded from
[here](https://github.com/protocolbuffers/protobuf/releases/tag/v3.12.4) and
adding it to my path:
```sh
datafusion ❯ PATH="$HOME/protobuf/bin:$PATH" cargo doc
…
Error: Custom { kind: Other, error: "protoc failed: substrait/algebra.proto:
This file contains proto3 optional fields, but
--experimental_allow_proto3_optional was not set.\n" }
datafusion ❯ PATH="$HOME/protobuf/bin:$PATH" cargo doc --features protoc
Finished `dev` profile [unoptimized + debuginfo] target(s) in 7m 10s
Generated
/Users/wendell.smith/go/src/github.com/DataDog/datafusion/target/doc/datafusion/index.html
and 42 other files
```
So I think probably all that needs doing is adding the directive for
`docs.rs` to use the feature:
https://github.com/substrait-io/substrait-rs/blob/bbcc9f6d0b084a13706f39a43bbba9d37bf2a959/Cargo.toml
That said - I _think_ that should be done in
`datafusion/substrait/Cargo.toml`, and not the workspace `Cargo.toml`, and I'm
not entirely certain, and I'm not sure how to find out. I've tried to run
`docs.rs` locally following the instructions
[here](https://github.com/rust-lang/docs.rs/blob/master/README.md#build-subcommand)
and
[here](https://forge.rust-lang.org/docs-rs/add-dependencies.html#testing-the-image),
but I haven't been able to reproduce the `experimental_allow_proto3_optional
was not set` error.
We could just add that directive to `datafusion/substrait/Cargo.toml` and
see if it fixes it in the next version? Any other ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
