alamb opened a new issue, #13853: URL: https://github.com/apache/datafusion/issues/13853
### Describe the bug The substrait API docs on docs.rs are broken ### To Reproduce Go to: https://docs.rs/crate/datafusion-substrait/latest <img width="1665" alt="Screenshot 2024-12-19 at 5 26 12 PM" src="https://github.com/user-attachments/assets/d2cea556-ecde-48a1-8a9f-80a342eabfc2"; /> According to the build log https://docs.rs/crate/datafusion-substrait/43.0.0/builds/1509810 It appears that the issue is that issue is with the protobuf compiler for some reason 🤔 ``` # rustc version rustc 1.84.0-nightly (b91a3a056 2024-11-07)# docs.rs version docsrs 0.6.0 (36c721fb 2024-11-06)# build log [INFO] running `Command { std: "docker" "create" "-v" "/home/cratesfyi/workspace/builds/datafusion-substrait-43.0.0/target:/opt/rustwide/target:rw,Z" "-v" "/home/cratesfyi/workspace/builds/datafusion-substrait-43.0.0/source:/opt/rustwide/workdir:ro,Z" "-v" "/home/cratesfyi/workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/home/cratesfyi/workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "DOCS_RS=1" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "6442450944" "--cpus" "6" "--user" "1001:1001" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4a844ea9eb2546a2d2c7022eacef16ef2e8229c7fbb2c7d4d55a9ceca922f72d" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "rustdoc" "--lib" "-Zrustdoc-map" "--config" "build.rustdocflags=[\"--cfg\", \"docsrs\", \"-Z\", \"unstable-options\", \"--emit=invocation-s pecific\", \"--resource-suffix\", \"-20241107-1.84.0-nightly-b91a3a056\", \"--static-root-path\", \"/-/rustdoc.static/\", \"--cap-lints\", \"warn\", \"--extern-html-root-takes-precedence\"]" "--offline" "-Zunstable-options" "--config=doc.extern-map.registries.crates-io=\"https://docs.rs/{pkg_name}/{version}/x86_64-unknown-linux-gnu\""; "-Zrustdoc-scrape-examples" "-j6" "--target" "x86_64-unknown-linux-gnu", kill_on_drop: false }` [INFO] [stdout] de980afb472a6e766f3e4cf8abce4491593d423f3235b3103d0ab7cb4458b1ad [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "de980afb472a6e766f3e4cf8abce4491593d423f3235b3103d0ab7cb4458b1ad", kill_on_drop: false }` [INFO] [stderr] warning: target filter specified, but no targets matched; this is a no-op [INFO] [stderr] Compiling substrait v0.45.5 [INFO] [stderr] error: failed to run custom build command for `substrait v0.45.5` [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `/opt/rustwide/target/debug/build/substrait-c1b9d73c7644dfe1/build-script-build` (exit status: 1) [INFO] [stderr] --- stdout [INFO] [stderr] cargo:rerun-if-env-changed=FORCE_REBUILD [INFO] [stderr] cargo:rerun-if-changed=substrait [INFO] [stderr] cargo:rerun-if-changed=substrait/text/simple_extensions_schema.yaml [INFO] [stderr] cargo:rerun-if-changed=substrait/proto/substrait/extended_expression.proto [INFO] [stderr] cargo:rerun-if-changed=substrait/proto/substrait/algebra.proto [INFO] [stderr] cargo:rerun-if-changed=substrait/proto/substrait/function.proto [INFO] [stderr] cargo:rerun-if-changed=substrait/proto/substrait/type.proto [INFO] [stderr] cargo:rerun-if-changed=substrait/proto/substrait/capabilities.proto [INFO] [stderr] cargo:rerun-if-changed=substrait/proto/substrait/plan.proto [INFO] [stderr] cargo:rerun-if-changed=substrait/proto/substrait/type_expressions.proto [INFO] [stderr] cargo:rerun-if-changed=substrait/proto/substrait/parameterized_types.proto [INFO] [stderr] cargo:rerun-if-changed=substrait/proto/substrait/extensions/extensions.proto [INFO] [stderr] [INFO] [stderr] --- stderr [INFO] [stderr] Error: Custom { kind: Other, error: "protoc failed: substrait/algebra.proto: This file contains proto3 optional fields, but --experimental_allow_proto3_optional was not set.\n" } [INFO] running `Command { std: "docker" "inspect" "de980afb472a6e766f3e4cf8abce4491593d423f3235b3103d0ab7cb4458b1ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de980afb472a6e766f3e4cf8abce4491593d423f3235b3103d0ab7cb4458b1ad", kill_on_drop: false }` [INFO] [stdout] de980afb472a6e766f3e4cf8abce4491593d423f3235b3103d0ab7cb4458b1ad ``` ### Expected behavior _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
