alamb commented on code in PR #14032:
URL: https://github.com/apache/datafusion/pull/14032#discussion_r1907263612
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -466,7 +465,8 @@ impl DefaultPhysicalPlanner {
.collect::<Result<Vec<Arc<dyn PhysicalExpr>>>>()
})
.collect::<Result<Vec<_>>>()?;
- let value_exec =
ValuesExec::try_new(SchemaRef::new(exec_schema), exprs)?;
+ let value_exec =
+ MemoryExec::try_new_as_values(SchemaRef::new(exec_schema),
exprs)?;
Review Comment:
👍
##########
datafusion/physical-plan/src/memory.rs:
##########
@@ -293,6 +383,15 @@ impl MemoryExec {
Boundedness::Bounded,
)
}
+
+ fn compute_properties_as_value(schema: SchemaRef) -> PlanProperties {
Review Comment:
is this something we should do prior to merging the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
