alamb commented on code in PR #14032:
URL: https://github.com/apache/datafusion/pull/14032#discussion_r1905509497
##########
datafusion/physical-plan/src/values.rs:
##########
@@ -34,6 +34,7 @@ use datafusion_execution::TaskContext;
use datafusion_physical_expr::EquivalenceProperties;
/// Execution plan for values list based relation (produces constant rows)
+#[deprecated(since = "44.0.0", note = "Use `MemoryExec::try_new_as_values`
instead")]
Review Comment:
Since we have already released 44, I think the correct version is the next
unreleased one, 45
```suggestion
#[deprecated(since = "45.0.0", note = "Use `MemoryExec::try_new_as_values`
instead")]
```
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -466,6 +467,7 @@ impl DefaultPhysicalPlanner {
.collect::<Result<Vec<Arc<dyn PhysicalExpr>>>>()
})
.collect::<Result<Vec<_>>>()?;
+ #[allow(deprecated)] // TODO: Remove in favour of MemoryExec
Review Comment:
In this PR I think it would be good to port this code (in the physical
planner) to use `MemoryExec` -- that way queries will run through `MemoryExec`
and we will confidence that `ValuesExec` can really be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
