vbarua commented on code in PR #13963:
URL: https://github.com/apache/datafusion/pull/13963#discussion_r1900285794
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -3082,180 +3087,6 @@ fn from_substrait_literal(
Ok(scalar_value)
}
-fn from_substrait_null(
- consumer: &impl SubstraitConsumer,
- null_type: &Type,
- dfs_names: &[String],
- name_idx: &mut usize,
-) -> Result<ScalarValue> {
Review Comment:
The match block below is effectively replaced by converting the Substrait
Type to a DataFusion DataType, and then invoking `ScalarValue::try_from` which
does the same thing effectively:
https://github.com/apache/datafusion/blob/9eca7d165c3ddcd3449e833df9391b8216e0f5bc/datafusion/common/src/scalar/mod.rs#L3408-L3523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
