iffyio commented on code in PR #1538: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1538#discussion_r1896650574
########## src/parser/mod.rs: ########## @@ -11375,7 +11466,11 @@ impl<'a> Parser<'a> { } else { let object_type = self.parse_one_of_keywords(&[Keyword::SEQUENCE, Keyword::SCHEMA, Keyword::TABLE]); - let objects = self.parse_comma_separated(|p| p.parse_object_name(false)); + let objects = if dialect_of!(self is MySqlDialect | GenericDialect) { + self.parse_comma_separated(|p| p.parse_object_name_with_wildcards(false, true)) + } else { + self.parse_comma_separated(|p| p.parse_object_name(false)) + }; Review Comment: Ah yeah that would be fine, the dialect impls can accept a superset of the actual sql spec -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org