mvzink commented on code in PR #1538:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1538#discussion_r1893325618
##########
src/parser/mod.rs:
##########
@@ -8353,20 +8409,40 @@ impl<'a> Parser<'a> {
}
}
+ /// Parse a possibly qualified, possibly quoted identifier, optionally
allowing for wildcards,
+ /// e.g. *, `foo`.*, or "foo"."bar"
+ pub fn parse_object_name_with_wildcards(
Review Comment:
Sorry it's taken me a while to get to this. It's a bit tricky, partly
because the expression form shouldn't accept `*.*`. I will try to come back to
this later, but have had higher priorities the last few weeks and probably will
until later in January. In my opinion, it might be better to avoid dragging on
with more merge conflicts etc. and merge without this suggested refactor. Let
me know your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
