alamb commented on code in PR #13767:
URL: https://github.com/apache/datafusion/pull/13767#discussion_r1893401168
##########
datafusion/sql/src/statement.rs:
##########
@@ -685,19 +717,99 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
Statement::ShowTables {
extended,
full,
- db_name,
- filter,
- // SHOW TABLES IN/FROM are equivalent, this field specifies
which the user
- // specified, but it doesn't affect the plan so ignore the
field
- clause: _,
- } => self.show_tables_to_plan(extended, full, db_name, filter),
+ terse,
+ history,
+ external,
+ show_options,
+ } => {
+ // We only support the basic "SHOW TABLES"
+ // https://github.com/apache/datafusion/issues/3188
+ if extended {
+ return not_impl_err!("SHOW TABLES EXTENDED not
supported")?;
+ }
+ if full {
+ return not_impl_err!("SHOW FULL TABLES not supported")?;
+ }
+ if terse {
+ return not_impl_err!("SHOW TERSE TABLES not supported")?;
+ }
+ if history {
+ return not_impl_err!("SHOW TABLES HISTORY not supported")?;
+ }
+ if external {
+ return not_impl_err!("SHOW EXTERNAL TABLES not
supported")?;
+ }
+ let ShowStatementOptions {
+ show_in,
+ starts_with,
+ limit,
+ limit_from,
+ filter_position,
+ } = show_options;
+ if show_in.is_some() {
+ return not_impl_err!("SHOW TABLES IN not supported")?;
+ }
+ if starts_with.is_some() {
+ return not_impl_err!("SHOW TABLES LIKE not supported")?;
+ }
+ if limit.is_some() {
+ return not_impl_err!("SHOW TABLES LIMIT not supported")?;
+ }
+ if limit_from.is_some() {
+ return not_impl_err!("SHOW TABLES LIMIT FROM not
supported")?;
+ }
+ if filter_position.is_some() {
+ return not_impl_err!("SHOW TABLES FILTER not supported")?;
+ }
+ self.show_tables_to_plan()
+ }
Statement::ShowColumns {
extended,
full,
- table_name,
- filter,
- } => self.show_columns_to_plan(extended, full, table_name, filter),
+ show_options,
+ } => {
+ let ShowStatementOptions {
Review Comment:
It was caused by changes in the SQL Parser AST -- specifically I think it
was introduced in
- https://github.com/apache/datafusion-sqlparser-rs/pull/1501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
