alamb commented on code in PR #13767:
URL: https://github.com/apache/datafusion/pull/13767#discussion_r1884707392
##########
datafusion/sql/src/statement.rs:
##########
@@ -200,7 +204,6 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
statement: Statement,
planner_context: &mut PlannerContext,
) -> Result<LogicalPlan> {
- let sql = Some(statement.to_string());
Review Comment:
This change was needed because otherwise `tpcds_logical_q64` overflowed its
stack
https://github.com/apache/datafusion/actions/runs/12322166828/job/34395679472?pr=13767
```
thread 'tpcds_logical_q64' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
```
I traced it down locally and apparently trying to format the deeply nested
query was actually overflowing at this spot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
