Blizzara commented on PR #13803: URL: https://github.com/apache/datafusion/pull/13803#issuecomment-2551239991
> I think it makes sense to do that, and I'm happy to own it, but I would prefer to do that as a followup. I structured the `consumer.rs` changes in order to make it easy to see that the functions I added were extracted from the big `from_substrait_rel` and `from_substrait_rex` switch statements. Yup, I totally agree! I looked through the latest changes, looks even better now, just some more comments re SubstraitPlanningState but otherwise this looks very good by me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
