vbarua commented on code in PR #13803:
URL: https://github.com/apache/datafusion/pull/13803#discussion_r1889330504
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -2037,42 +2438,48 @@ fn from_substrait_type(
Ok(DataType::Interval(IntervalUnit::MonthDayNano))
}
r#type::Kind::UserDefined(u) => {
- if let Some(name) = extensions.types.get(&u.type_reference) {
+ if let Ok(data_type) = consumer.consume_user_defined_type(u) {
+ return Ok(data_type);
+ }
+
+ // TODO: remove the code below once the producer has been
updated
Review Comment:
I thought about removing it as part of this PR, but figured that would be
better handled as a separate follow-up change. I'm already breaking enough API
with this as is 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
