vbarua commented on code in PR #13803:
URL: https://github.com/apache/datafusion/pull/13803#discussion_r1894401830
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -989,8 +992,13 @@ async fn extension_logical_plan() -> Result<()> {
}),
});
+ let consumer = DefaultSubstraitConsumer::new(
+ Arc::new(Extensions::default()),
+ Arc::new(ctx.state()),
+ );
+
let proto = to_substrait_plan(&ext_plan, &ctx.state())?;
- let plan2 = from_substrait_plan(&ctx.state(), &proto).await?;
+ let plan2 = from_substrait_plan_with_consumer(&consumer, &proto).await?;
Review Comment:
I've updated this to call `from_substrait_plan`. This is a holdover from an
earlier design in which the DefaultSubstraitConsumer didn't handle extension
relations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
