Blizzara commented on code in PR #13803:
URL: https://github.com/apache/datafusion/pull/13803#discussion_r1888753594
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -2037,42 +2438,48 @@ fn from_substrait_type(
Ok(DataType::Interval(IntervalUnit::MonthDayNano))
}
r#type::Kind::UserDefined(u) => {
- if let Some(name) = extensions.types.get(&u.type_reference) {
+ if let Ok(data_type) = consumer.consume_user_defined_type(u) {
+ return Ok(data_type);
+ }
+
+ // TODO: remove the code below once the producer has been
updated
Review Comment:
I think the producer doesn't produce any of these anymore, we just didn't
remove them yet in case someone is producing plans with an older version and
trying to run them with a newer one. Or like, run a plan that has been stored
somewhere. But maybe it's time to remove them from the next version for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
