comphead commented on code in PR #13576:
URL: https://github.com/apache/datafusion/pull/13576#discussion_r1882910154
##########
datafusion/common/src/config.rs:
##########
@@ -470,7 +478,7 @@ config_namespace! {
/// delta_byte_array, rle_dictionary, and byte_stream_split.
/// These values are not case sensitive. If NULL, uses
/// default parquet writer setting
- pub encoding: Option<String>, default = None
+ pub encoding: Option<String>, transform = str::to_lowercase, default =
None
Review Comment:
What I mean is since the new field `transform` introduced, it is good to
highlight how this field is gonna be used.
Previously the config structs were the same format having a config field and
a default value and it was self-explanatory. Having introduced the `transform`
I feel its needed to comment how its gonna be used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
