berkaysynnada commented on PR #13576: URL: https://github.com/apache/datafusion/pull/13576#issuecomment-2538045753
> hey @berkaysynnada, by future-proof solution do you mean [synnada-ai@341b484#diff-2f697c310af1a48521829d8bd665cf64b6415fbf88edd370efa30b1ed686354dR1655](https://github.com/synnada-ai/datafusion-upstream/commit/341b48458c09f25d2a5873fcee2fce18eb0e1097#diff-2f697c310af1a48521829d8bd665cf64b6415fbf88edd370efa30b1ed686354dR1655)? I agree that fine-grained control is better, but isn't it similar to how I implemented it? e.g. > > https://github.com/apache/datafusion/blob/06c013d7113d8618b12e490fb45533f8e6fdf19e/datafusion/common/src/config.rs#L442 Sorry, I have missed your reply. After looking more in detail, you did actually what I referred. I just wonder can we remove that config setting at all 🤔 because now every option can modify the input as intended, and the users should write knowing that behavior -- for example an option is case sensitive, you would know that and write accordingly. But if it's not a specific option and just takes some elements from a set, and then you would know they are all normalized. In which scenarios does that config setting get a meaning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
