alamb commented on code in PR #13576:
URL: https://github.com/apache/datafusion/pull/13576#discussion_r1880108716
##########
datafusion/common/src/config.rs:
##########
@@ -212,11 +219,12 @@ config_namespace! {
pub enable_ident_normalization: bool, default = true
/// When set to true, SQL parser will normalize options value (convert
value to lowercase)
- pub enable_options_value_normalization: bool, default = true
+ pub enable_options_value_normalization: bool, default = false
Review Comment:
FWI @xinlifoobar and @berkaysynnada who worked on
https://github.com/apache/datafusion/pull/11330 where this feature was added.
Interestingly, this option was added in response to seemingly the same problem
(AWS access keys being normalized) as faced by @tinfoil-knight here:
- https://github.com/apache/datafusion/issues/10853
Rather than changing the default config values, we could potentially change
the default in datafusion cli and/or improve documentation as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
