parthchandra commented on code in PR #1162: URL: https://github.com/apache/datafusion-comet/pull/1162#discussion_r1881037044
########## spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala: ########## @@ -132,7 +132,7 @@ case class CometScanExec( lazy val bucketedScan: Boolean = wrapped.bucketedScan override lazy val (outputPartitioning, outputOrdering): (Partitioning, Seq[SortOrder]) = - (wrapped.outputPartitioning, wrapped.outputOrdering) + (UnknownPartitioning(wrapped.inputRDD.getNumPartitions), wrapped.outputOrdering) Review Comment: I did this based on what we do in CometNativeScanExec as well as the original output partition. The original wrapped.outputPartitioning for CometScanExec inherits from FileSourceScanLike and this returns a hardcoded ` UnknownPartitioning(0)` for non-bucketed scan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
