andygrove commented on code in PR #1162: URL: https://github.com/apache/datafusion-comet/pull/1162#discussion_r1880771710
########## spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala: ########## @@ -132,7 +132,7 @@ case class CometScanExec( lazy val bucketedScan: Boolean = wrapped.bucketedScan override lazy val (outputPartitioning, outputOrdering): (Partitioning, Seq[SortOrder]) = - (wrapped.outputPartitioning, wrapped.outputOrdering) + (UnknownPartitioning(wrapped.inputRDD.getNumPartitions), wrapped.outputOrdering) Review Comment: We were seeing zero partitions. Here is some debug output from testing: ``` firstNonBroadcastPlan = Some((CometScan parquet [_1#6,_2#7] Batched: true, DataFilters: [isnotnull(_1#6)], Format: CometParquet, Location: InMemoryFileIndex(1 paths)[file:/tmp/spark-a21845bf-72dc-49d1-94f0-f785bb6f2f18], PartitionFilters: [], PushedFilters: [IsNotNull(_1)], ReadSchema: struct<_1:int,_2:int> ,0)) firstNonBroadcastPlanNumPartitions = Some(0) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
