viirya commented on code in PR #1162: URL: https://github.com/apache/datafusion-comet/pull/1162#discussion_r1880770247
########## spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala: ########## @@ -132,7 +132,7 @@ case class CometScanExec( lazy val bucketedScan: Boolean = wrapped.bucketedScan override lazy val (outputPartitioning, outputOrdering): (Partitioning, Seq[SortOrder]) = - (wrapped.outputPartitioning, wrapped.outputOrdering) + (UnknownPartitioning(wrapped.inputRDD.getNumPartitions), wrapped.outputOrdering) Review Comment: What the output partitioning is when it fails the test? I assume that the `outputPartitioning` should have correct partition number but not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
