findepi commented on code in PR #13706: URL: https://github.com/apache/datafusion/pull/13706#discussion_r1877891404
########## docs/source/user-guide/sql/dialect.md: ########## @@ -0,0 +1,38 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# SQL Dialect + +By default, Apache DataFusion follows the [PostgreSQL SQL dialect]. +For Array/List functions and semantics, it follows the [DuckDB SQL dialect]. + +[duckdb sql dialect]: https://duckdb.org/docs/sql/functions/array +[postgresql sql dialect]: https://www.postgresql.org/docs/current/sql.html Review Comment: Is this dualism good for users? i think the market formed consensus to regard PostgreSQL-compatible as a good thing. Why do we water this down to say PostgreSQL-compatible, except where not? It's going to be confusing and incoherent for example these expressions should be equivalent 1. `2 IN (1, NULL, 3)` 2. `2 in (SELECT * FROM (VALUES (1), (NULL), (3)))` 3. is `2` in `[1, NULL, 3]` array whereas we say that first two are governed by "be like PostgreSQL" goal and the last is governed by "be like DuckDB" goal Why would users appreciate that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
