iffyio commented on code in PR #1580:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1580#discussion_r1876252525
##########
tests/sqlparser_snowflake.rs:
##########
@@ -2952,3 +2950,19 @@ fn test_sf_double_dot_notation() {
#[test]
fn test_parse_double_dot_notation_wrong_position() {}
+
+#[test]
+fn test_table_sample() {
+ snowflake_and_generic().one_statement_parses_to(
+ "SELECT * FROM testtable SAMPLE (10)",
+ "SELECT * FROM testtable TABLESAMPLE (10)",
+ );
Review Comment:
Oh could we do the same here as well? clickhouse for example doesn't have
has `SAMPLE` but not `TABLESAMPLE` so that the roundtrip stays correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
